search

example42 / puppet-firewall

Example42 Firewall abstraction meta-module
http://www.example42.com
Other
3 stars 11 forks source link

Refactored some for version 3 #9

Closed Freeaqingme closed 11 years ago

alvagante commented 11 years ago

Given that the whole firewall / iptables integration is quite critical I've created a devel branch also here in order to avoid messing with current setups. Also, considering that the migration to 3 module will probably be gradual I think that, for these cases, we should manage the firewall and iptables new classes leaving backwards compatibility so that both 2.x and 3.x modules can cohexist. If there's full backwards compatibility I might merge these fixes in any moment and we can start to test usage patterns with the new modules.

Freeaqingme commented 11 years ago

If there's full backwards compatibility I might merge these fixes in any moment and we can start to test usage patterns with the new modules.

I've maintained BC in 1 direction. This module can be used with 2.0 modules (we simply can't update them all at once), but it does require version 3 of the iptables module. Github has no way of proposing new branches, as such I filed a PR against the existing branch. Will a file a new one for the other branch, and close this one.

=> Closed.

Freeaqingme commented 11 years ago

@example42 On a sidenote, if the firewall module version 3 is used with iptables version 2, compilation will fail. A good thing, cause there's no 'quiet' breaks.

alvagante commented 11 years ago

That's ok for me. My only concern is the requirement for the future parser in the iptables module