search

example42 / puppet-iptables

Iptables Puppet Module (for host based firewalling)
http://www.example42.com
Other
14 stars 41 forks source link

ripienaar-concat requirement? #13

Closed empi89 closed 11 years ago

empi89 commented 11 years ago

Hey,

doesn't this module require the module ripienaar-concat?

I have installed this package via the puppetforge and got the errror "Error 400 on SERVER: Could not find class concat::setup" on using the module (just embedded "class { 'iptables' :}"). After installing ripienaar-concat via puppetforge this module runs smooth ;-).

Suggestion: Make this module depend on e.g. the ripienaar-concat implementation.

Best Regards Peter

alvagante commented 11 years ago

True. By default concat mode is enabled and that's the part which requires ripienaar-concat, so it makes sense to add the dependency in Modulefile, just committed the fix https://github.com/example42/puppet-iptables/commit/19eb494916927a2bce8a4846548add933f592844 , but it won't be available readily on the Forge.

gvt commented 11 years ago

+1 on this issue. Puppet Forge seems to not have this update even now.

alvagante commented 11 years ago

To update the modules on the Forge is still slow and cumbersome. Please use the github versions.

gvt commented 11 years ago

I found the FAQ on Google Groups and tried using the Github versions last night and it was better, thanks. So much simpler to use Puppet Forge though, too bad they are inconvenient to use.