search

example42 / puppet-iptables

Iptables Puppet Module (for host based firewalling)
http://www.example42.com
Other
14 stars 41 forks source link

IPv6 is working for upuntu >12.04 #17

Closed jerger closed 11 years ago

jerger commented 11 years ago

Hi,

the IPV6 enhancement is now working (in my maschine - but should on others also :-). Your review and any comments is most welcome.

Best regards, Michael

alvagante commented 11 years ago

Wonderful work, thank you. Unfortunately I can't test it properly since my notebook (with my vagrant puppet playgrounds) is under repair. Please patient some days and maybe give a look to my inline comments.

jerger commented 11 years ago

It's a pleasure to learn from your code - so I'm happy to give some code back to you. Regarding your notebook - I'm quite relaxed and not in hurry :-)

Freeaqingme commented 11 years ago

@jerger Thanks for this awesome pull request.

@example42 How's your notebook doing? Would be great if this PR could be merged (for now i'll just use @jerger's repo - long live git).

alvagante commented 11 years ago

Hehe, notebook is ok. To be honest I merged @jerger code in a branch and started to work on its integration with the firewall metamodule, but then I got lost after other tasks... Will come back on this for sure, once I exit a particularly busy period (after Easter?). Anyway I can confirm that the patch keeps background compatibility, which was a critical point for me.

jerger commented 11 years ago

@example42 Geting lost in heavy work is something I can empathize quite well :-) Is there anything left I can do supportively?

alvagante commented 11 years ago

Well, actually I seem to have lost the branch I was working on... so have to redo the firewall integration part, I suppose. I could merge your code and the work on it, when I tried I saw no compatibility problems, but it was a somehow limited test, @jerger and @Freeaqingme can you confirm that the PR doesn't break an existing setup (at least yours)?

Freeaqingme commented 11 years ago

@example42 Unfortunately I haven't yet. I should be able to let you know something later this week. /cc @jerger

jerger commented 11 years ago

Hi, I can confirm, that the code works on my machines ... (but as you know certainly, "works on my machine" is true for numerous buggy software-pieces :-). Seriously - my changes are minimal and i did my best to stay compatible.

alvagante commented 11 years ago

Merged, finally, fyi had to fix a pair of minor conflicts. Great job :+1:

Freeaqingme commented 11 years ago

I'm truly sorry for not getting back at this. I realized that we didn't have full ipv6 support on our network yet, and as such I couldn't fully test it. I've scheduled a maintenance window this week to get that done, and surely then will check it out .

@jerger Anyways, I'm really grateful for your efforts, saves me tons of time.