search

example42 / puppet-iptables

Iptables Puppet Module (for host based firewalling)
http://www.example42.com
Other
14 stars 41 forks source link

concat: added force #49

Closed empi89 closed 10 years ago

empi89 commented 10 years ago

Because of a potential bug in puppetlabs-concat force is needed here. See https://github.com/puppetlabs/puppetlabs-concat/commit/00a8f4e73695eb93529942b31d0580df17ee9393#diff-4050c10d82ce9debdbe92764ddf021e4R101 for the comment on that bug.

alvagante commented 10 years ago

@jerger The involved part of code is mostly written by you, any feedback on this fix?

Freeaqingme commented 10 years ago

Am I understanding correctly this only poses an issue if you have no firewall rule defined at all?

jerger commented 10 years ago

The proposed change sounds fine to me. As soon as travis ci works again I offer a short test w. an sunrising server and also with existing installations.

alvagante commented 10 years ago

Ok, fixed the spec tests to have Travis green again.

jerger commented 10 years ago

will test tomorrow :-)

jerger commented 10 years ago

Works on new node.

jerger commented 10 years ago

I tested on a old node and the new iptables is compatible in the results. So from my side the proposed changes are fine.