Closed jhoblitt closed 8 years ago
It looks like puppi::netinstall
needs a new param to allow you to pass in the true filename to override the url parsing. https://github.com/example42/puppi/blob/master/manifests/netinstall.pp#L80
I've slow internet connection in these days so I can't test, but it seems that urls like this: '4' => 'http://sourceforge.net/projects/jboss/files/JBoss/JBoss-4.2.3.GA/jboss-4.2.3.GA.zip', instead of '4' => 'http://sourceforge.net/projects/jboss/files/JBoss/JBoss-4.2.3.GA/jboss-4.2.3.GA.zip/download', are enough to get the zip. They are set here: https://github.com/example42/puppet-jboss/blob/master/manifests/init.pp#L426 If so , so if the name of the extracted dir is jboss-4.2.3.GA puppi::netinstall should work (otherwise it should be enough to fix puppi::netinstall's extracted_dir parameter in the jboss class.
If you can test the module with the fixed urls, otherwise I'll check it later.
As expected, the URL change fixes it and I've opened #22 with this change. I still feel like it's probably worth while for puppi::netinstall
to be able to handle that situation. Should I open another issue on puppi
?
Sorry for laate reply. I don't think it's necessary to make changes on puppi::netinstalll, the extracted_dir param can be used to cope with such situations.
It appears that puppi/etc. is expecting the basename of the URL to be name of the file actually downloaded while this isn't the case for the URLs to download jboss 4/5.