Closed signed closed 7 years ago
Wouldn't it be better to add this as an option?
I am pretty new to puppet and do not know the option concept. I copied the approach you took with the bindaddr parameter. Can you point me to some document/samples where I can read up?
I would leave the default value of bindaddr_admin_console to '' (empty) If the user specifies a value then you use it and the admin console is activate. On the erb template where you set: JBOSS_BIND_ADDR_ADMIN_CONSOLE=${JBOSS_HOST:-"-bmanagement <%= @bindaddr_admin_console %>"} you can place an if statement that adds the above line if bindaddr_admin_console is not '' then you add the above line, else you add something like: JBOSS_BIND_ADDR_ADMIN_CONSOLE=""
Thx for explaining this to me. I changed the code as you proposed.
Allow remote access to the admin console