example42 / puppet-kibana

Puppet module for Kibana 3 based on stdmod naming standards
Other
9 stars 11 forks source link

Enhancement - Add ability to change default route in config.js #6

Open pythianali opened 10 years ago

pythianali commented 10 years ago

I ran into an issue https://github.com/elasticsearch/kibana/issues/834 and the workaround is to use the logstash.json dashboard as the default one.

Requesting that the ability to configure the default_route parameter in the config.js be made available in the class configuration.

pythianali commented 10 years ago

I did a workaround in my node declaration:

file_line { 'logstash dashboard': path => '/opt/kibana-latest/config.js', line => " default_route : '/dashboard/file/logstash.json',", match => ' default_route', }

This works well.

alvagante commented 10 years ago

+1. I'd prepare a config.js template correctly configured, which users might enable with something like:

class { 'kibana':
  file_template => 'kibana/config.js',
} 

and leave two notes in the README. PR welcomed

paschdan commented 10 years ago

in #8 a basic config.js template was introduced, maybe we can enhance this one after it is merged :)

alvagante commented 10 years ago

merged #8 this might help to manage these cases...