example42 / puppet-modules-nextgen

Example42 Puppet Modules Version 2.x
http://www.example42.com
Other
83 stars 23 forks source link

rvm::dependencies should not define Package['wget'] etc #1

Closed chancancode closed 11 years ago

chancancode commented 12 years ago

I uses the rvm module and I am currently writing another one that depends on libcurl (and also needs to be executed before the main Stage, just like rvm). However, there are no easy way for me to specufy the libcurl package as a dependency, because rvm::dependencies already defined that package (which is not the same thing as the package being installed yet at this point). "if ! defined" guards does not help in this situation even though it sounds like they should. (See https://gist.github.com/5b4214d40faac47d4c0c) The only reliable way to do this right now is to require rvm::dependencies in my module, which is clearly not ideal.

These dependencies should probably be moved out of rvm into a shared package that can be required by other classes.

alvagante commented 11 years ago

Sorry for so late reply, I'm trying now to review all the pending issues and I totally forgot this one. The rvm module has been forked, so I suppose this apply to the upstream version. In any case I suppose you've found your way of this... closing the ticket and sorry again.