example42 / puppet-modules-nextgen

Example42 Puppet Modules Version 2.x
http://www.example42.com
Other
83 stars 23 forks source link

Add example42-style pdns_recursor #8

Closed erik-smit closed 11 years ago

alvagante commented 11 years ago

A pair of notes:

erik-smit commented 11 years ago
  1. PowerDNS Recursive Server and PowerDNS Authoritive Server are separate products. This module is not an 'recursive' implementation of PowerDNS. This module is an implementation of PowerDNS Recursive Server.
  2. The alternate would be to create a behemoth Munin module, carrying plugins and configurations for everything it needs to support. Or to create a munin-companion-module for every single daemon, which would make the module-tree even more cluttered and unhierarchical than it already is. The current solution is easily managable for me and like you said, disabled by default it probably won't do any harm, while still providing benefit for my usecase.
  3. Does not bother me.
  4. Hm, that does make sense. I always forget that part, and when I think about it I don't want to grab out the editor, git, etc. just for some naming. Maybe make the module_clone tool grab the git.user/git.email to autofill these fields? If you're cool with that, I could pull request it.
alvagante commented 11 years ago

Sorry for late reply, just exited a quite busy period, maybe. I added your repo directly in 1c46b587ac56b764e1ccb2c7d37042b874385285 so it points to your github account.

A patch to the module_clone.sh script to fit username and email would be very appreciated, when possible.