search

example42 / puppet-mongodb

Puppet module for MongoDB
Apache License 2.0
8 stars 9 forks source link

Parameter noop failed on Package[mongodb]: Invalid value "" #8

Closed erikanderson closed 8 years ago

erikanderson commented 9 years ago

puppet 3.8.2 stringify_facts = false parser = future

Error: Failed to apply catalog: Parameter noop failed on Package[mongodb]: Invalid value "". Valid values are true, false. at /modules/mongodb/manifests/server.pp:7

erikanderson commented 9 years ago

I fixed this temporarily by setting (in params.pp) $noops = undef to $noops = false I feel like this would be a sensible default

alvagante commented 9 years ago

Actually this whole noops thing has not been good idea. You solution works but is dangerous, as it ignores an eventuall --noop option passed via the command line. I'd rather remove any reference to this noop parameter in the class. As done here: https://github.com/example42/puppet-logrotate/commit/5372c8a3185ce3a60cce593c830917cef8e92b3c

(PR welcomed)