example42 / puppet-mysql

Mysql Puppet Module
http://www.example42.com
Other
16 stars 38 forks source link

Added a new parameter for mysql_db_create_options to grant.pp #26

Closed jerger closed 11 years ago

jerger commented 11 years ago

Hi,

I've added a new parameter for mysql_db_create_options (I needed 'character set utf8' on my server). The default is set to '' so the the defined type should remain backward compatible.

Best regards, jerger

alvagante commented 11 years ago

Well, don't want to be picky, but a space is added to the existing file and therefore the mysql exec would be executed the same. The query anyway should be safe to be re-executed. Can you place an if statement in the template taking care to not introduce any space? :-)

jerger commented 11 years ago

sorry ... my fault - I've seen one test becomes red. Stay tuned for the immediately coming fix :-)

jerger commented 11 years ago

Fixed and added an additional test for the new parameter.

alvagante commented 11 years ago

Thanks lot :-)