Given that a refactoring of the nagios/icinga, nrpe , nsca , checkmk (still non existing) modules is probably needed, I would try to have each of these modules do its own stuff and be somehow indipendent.
Nagios plugins, IMHO, should stay either in a dedicated module or in a nagios::plugins class that can be included anywhere (also where Nagios is not installed).
I wouldn't move them inside an NRPE module since you could need Nagios plugins without having NRPE.
Also, given this, I would wipe out the redundant nrpe::plugin define.
Have to find time to collect the existing PR and ideas, though.
Given that a refactoring of the nagios/icinga, nrpe , nsca , checkmk (still non existing) modules is probably needed, I would try to have each of these modules do its own stuff and be somehow indipendent. Nagios plugins, IMHO, should stay either in a dedicated module or in a nagios::plugins class that can be included anywhere (also where Nagios is not installed). I wouldn't move them inside an NRPE module since you could need Nagios plugins without having NRPE. Also, given this, I would wipe out the redundant nrpe::plugin define. Have to find time to collect the existing PR and ideas, though.