search

example42 / puppet-nagios

Puppet module for Nagios
Other
4 stars 18 forks source link

Travis CI builds failing #35

Closed ghost closed 10 years ago

ghost commented 10 years ago

The Travis CI builds have been failing since example42@80a0867, which makes it difficult to verify that a pull request isn't really breaking anything.

The first build to fail was build 59, which was failing because of Unknown function is_array. That problem seems to have been fixed by issue #31, which is a little strange because I would have expected it to have been fixed by issue #34.

In any case, the error being generated now is:

  1) nagios Test standard installation with monitoring should monitor the process
     Failure/Error: content = catalogue.resource('monitor::process', 'nagios_process').send(:parameters)[:enable]
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./spec/classes/nagios_spec.rb:29:in `block (3 levels) in <top (required)>'

All of the tests pass locally for me, so I'm not sure where the problem is.

ghost commented 10 years ago

Alright, I found the problem. A new version of rspec-puppet was released on December 5th. The previous version, 0.1.6, did not expect any arguments to catalogue. In the 1.0.0 version, catalogue expects a single parameter. It's up to you how you want to fix it, but I think the easiest way would be to add the following to .gemfile:

gem 'rspec-puppet', '0.1.6'
alvagante commented 10 years ago

Thanks, the issue is for most of ex42 modules, your solution to specify the rspec-puppet version is definitively the quickest and most effective one till all the tests are fixed, which might take quite longer.