example42 / puppet-network

Puppet module to manage networking on Suse, Debian and RedHat.
Apache License 2.0
31 stars 166 forks source link

ip rule management for RedHat completely different structure and approach #227

Open igarny opened 6 years ago

igarny commented 6 years ago

Expected Behavior

similar approach as with Debian ip rule management #226

Actual Behavior

https://github.com/example42/puppet-network/blob/master/templates/rule-RedHat.erb

Steps to Reproduce the Problem

Specifications

Please add this info:

  1. Output of facter -p on the failing node (at least the OS related facts)
  2. Version of Puppet and of the module
  3. The relevant Puppet code and eventually Hiera data
alvagante commented 6 years ago

@igarny not sure on what you miss here, the ipv6 family support on RedHat based on the family parameter (and not eventually with ipv6 directly specified in the rule entry?)

igarny commented 6 years ago

All I'm stating is that both approaches for Debian and RedHat on ip rule management differ a lot, where it shouldn't. After all the implementation of the ip stack is very close in both flavors of Linux and the ip commands are the same. Also there is a risk to continue to diverge, them by having people adding specifics for Debian in the respective templates.