example42 / puppet-orientdb

OrientDB Puppet Module
http://www.example42.com
Other
7 stars 6 forks source link

Install from source tar.gz not working properly #2

Open jlafourc opened 10 years ago

jlafourc commented 10 years ago

Hi,

When I tried to install orientdb from source, I gave the url of tar.gz file.

In the end, there's a problem with the symbolic link created. Il points to .tar file. I changed the extension to .tgz and it's fine.

Julien

yasin-amadmia-mck commented 9 years ago

Hi, I came across same issue and have debugged to how the url_parse is implemented within puppi.

install.pp

source: {
  $created_dirname_full = url_parse($orientdb::real_install_source,'filedir')
  $created_dirname = regsubst($created_dirname_full,'-distribution','')

The filedir argument when passed to url_parse function (implemented in puppi) will only remove last-most extension from the url/path if file has got multiple extensions

ex: http://www.example.com/orientdb-x.tar.gz will return orientdb-x.tar, whereas, http://www.example.com/orientdb-x.tgz will return orientdb-x.

alvagante commented 9 years ago

ANy fix around here is welcomed: https://github.com/example42/puppet-orientdb/blob/master/manifests/install.pp#L28