example42 / puppet-php

A puppet module for php. According to Example42 NextGen spec.
Other
45 stars 62 forks source link

php package name required by module installation #100

Open apengue opened 9 years ago

apengue commented 9 years ago

in module.pp, on line 91 (last before closing parenthesis) there is:

require => Package['php'],

it should be

require => Package[$php::package],

otherwise, installing another php package (php55, php56 from another repo (epel/remi as example for Fedora/Centos/RHEL) will cause the module part to be ignored as the require clause will be missed.


update: same in init.php: 251: package { "${php::package}": 263: require => Package["${php::package}"],

alvagante commented 9 years ago

Good point, would you mind to submit a PR with the fixes?