Fix autorestart for separate ini files (#116)

example42 / puppet-php

A puppet module for php. According to Example42 NextGen spec.

Other

45 stars 62 forks source link

Fix autorestart for separate ini files (#116) #117

Closed stevenpost closed 8 years ago

stevenpost commented 8 years ago

This fixes issue #116 In addition to fixing the define, this PR also adds some basic rspec tests to verify the change.

Note: I have not tested it yet, only proven it correct (famous last words, not actually mine).

stevenpost commented 8 years ago

HI,

Reason for travis failues: The command "bundle install --jobs=3 --retry=3" failed and exited with 5 during . I doubt this has anything to do with the PR itself.

Also, I forgot to mention some behavioural change: it makes no sense to me to restart the webserver when changing the CLI, but not when changing something that actually affects the webserver, so changed that as well.

Regards, Steven

stevenpost commented 8 years ago

Right, this is the best I can do for now to keep travis happy, 1 failure. Can someone please take a look at it?