search

example42 / puppet-php

A puppet module for php. According to Example42 NextGen spec.
Other
45 stars 62 forks source link

Fix squashing of pear exit codes #73

Open Prill opened 9 years ago

Prill commented 9 years ago

Commit 286125b fixed an error from where badly encoded data would cause crashes, but the fix of piping it through iconv mean that the status code returned was that of iconv. This causes the module to always treat the pear module as "installed," meaning the install exec would never run. This changes fixes that by sending the standard output to /dev/null, which preserves the original exit code.

Prill commented 9 years ago

herp, looks like I need to update the test

Prill commented 9 years ago

The spec program fails to load module puppet/face on the Puppet 2.6.0 build. As far as I can tell that module only works with 2.7.0 or newer, and it looks like this is also failing on master.

alvagante commented 9 years ago

For me is ok, maybe @feychenie maybe give his opinion