search

example42 / puppet-php

A puppet module for php. According to Example42 NextGen spec.
Other
45 stars 62 forks source link

Missing variables and documentation #91

Open goetzk opened 9 years ago

goetzk commented 9 years ago

This role is missing some of its parameter definitions. While the work around is easy (define them) its unfortunate to find out they are missing by running the module.

I noticed that some of the missing variables (like those related to monitoring) are also missing from the documentation at the top of init.pp - I'm guessing some integration has gone awry somewhere.

# puppet agent --test --verbose
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Undefined variable "::php::params::monitor_tool"; Undefined variable "monitor_tool" at [...]
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Undefined variable "::php::params::monitor_target"; Undefined variable "monitor_target" at [...]
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Undefined variable "::php::params::config_file_init"; Undefined variable "config_file_init" at [...]
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Undefined variable "::php::params::pid_file"; Undefined variable "pid_file" at [...]

There might be others missing but this was the point where i stopped for today.

alvagante commented 9 years ago

As for the issue on puppi, the error should arise if you enable strict variables.