search

example42 / puppet-sudo

Puppet module to manage sudo
Other
4 stars 28 forks source link

redhat 5 sudo config_dir #16

Open lemonpeel opened 10 years ago

lemonpeel commented 10 years ago

Hello

params.pp sets up redhat 5 has config_dir = false

removing the line and falling back to the default /etc/sudoers.d works well for me on 5.10

I think this was needed in older redhat 5, looking at redhat network redhat 5.5 was the first to include package 1.7.2 which I think is the first redhat released sudo package to support includedir?

perhaps a test based on installed sudo package version would be better than splitting 5 into >= 5.5 and less that 5.5?

Thanks

Neil

alvagante commented 10 years ago

We need a fact that returns the sudo version and manage defaults according to its value instead of the OS version. A quick fix would be to refine the regexp in params.pp Note anyway that you can override all the parameters and set config_dir=> /etc/sudoers.d directly when declaring the class. PR welcomed.