example42 / puppet-tp

Tiny Puppet - The Universal Installer
http://tiny-puppet.com
Apache License 2.0
68 stars 21 forks source link

Added tests to tp_install #41

Closed alvagante closed 7 years ago

alvagante commented 7 years ago

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly
alvagante commented 7 years ago
2 Warnings
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.
:warning: Big PR! Big changes, big things may happen! Check them.
2 Messages
:book: Changes in tests but not in manifests. If they affect tests result, in theory this should not happen.
:book: There are changes on Hiera data files. They will probably affect one or more params.

Here's an example of a CHANGELOG.md entry:

* [#41](https://github.com/example42/puppet-tp/pull/41): Added tests to tp_install - [@alvagante](https://github.com/alvagante).

Generated by :no_entry_sign: Danger

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 93.783% when pulling bef74e1b9d66dc8ea4e39f606ed8564022074521 on more_tests into 10b4da5b6f3f8d5b4554aba1d61c836fb171000d on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.5%) to 94.19% when pulling 7e57efbb0ff7fc04d32f04a982f74afd7fd65e3c on more_tests into 10b4da5b6f3f8d5b4554aba1d61c836fb171000d on master.