search

example42 / puppet-tp

Tiny Puppet - The Universal Installer
http://tiny-puppet.com
Apache License 2.0
68 stars 21 forks source link

We still need pick_undef #43

Closed alvagante closed 7 years ago

alvagante commented 7 years ago

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly
alvagante commented 7 years ago
2 Warnings
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.
:warning: Big PR! Big changes, big things may happen! Check them.
1 Message
:book: There are changes on Hiera data files. They will probably affect one or more params.

Here's an example of a CHANGELOG.md entry:

* [#43](https://github.com/example42/puppet-tp/pull/43): We still need pick_undef - [@alvagante](https://github.com/alvagante).

Generated by :no_entry_sign: Danger

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.2%) to 93.144% when pulling 8884264f49d2de72d93cde7cc9b26db89620ca22 on 2.0.3 into 84382cef66c8a638ad30f095e014e3e4fbe6d003 on master.