example42 / puppet-tp

Tiny Puppet - The Universal Installer
http://tiny-puppet.com
Apache License 2.0
68 stars 21 forks source link

Added validate_syntax option to tp::conf #46

Closed alvagante closed 6 years ago

alvagante commented 6 years ago

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly
alvagante commented 6 years ago
2 Warnings
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.
:warning: Big PR! Big changes, big things may happen! Check them.
1 Message
:book: There are changes on Hiera data files. They will probably affect one or more params.

Here's an example of a CHANGELOG.md entry:

* [#46](https://github.com/example42/puppet-tp/pull/46): Added validate_syntax option to tp::conf - [@alvagante](https://github.com/alvagante).

Generated by :no_entry_sign: Danger

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 93.144% when pulling b6fee7f6419eea6b4d74063aaef9725d2db5b704 on validate_syntax into 3f8bae0e546587738a749280d6bd127478e03c24 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 93.189% when pulling 851f12710ad177a6b728db283fae73e910c2c2f2 on validate_syntax into 3f8bae0e546587738a749280d6bd127478e03c24 on master.