search

example42 / puppet-tp

Tiny Puppet - The Universal Installer
http://tiny-puppet.com
Apache License 2.0
68 stars 21 forks source link

Allow spaces in key for apt-key checks in tp::repo #57

Closed alvagante closed 5 years ago

alvagante commented 5 years ago

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly
alvagante commented 5 years ago
2 Warnings
:warning: There’re changes in manifests, but not tests. That’s OK as long as you’re refactoring existing code.
:warning: Unless you’re refactoring existing code or improving documentation, please update CHANGELOG.md.
1 Message
:book: There are changes on Hiera data files. They will probably affect one or more params.

Here's an example of a CHANGELOG.md entry:

* [#57](https://github.com/example42/puppet-tp/pull/57): Allow spaces in key for apt-key checks in tp::repo - [@alvagante](https://github.com/alvagante).

Generated by :no_entry_sign: Danger

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 95.734% when pulling 6f5a1fe8fbb6e6f19cfc7c607fe7301acaa83730 on fix_repo into 941b8b7ad9778c2014f06d579ba594fb634bc8e3 on master.