search

example42 / puppet-yum

Puppet module for Yum
Other
43 stars 116 forks source link

PR for issue #164, Change include to contain for better encapsulation #165

Closed critch closed 7 years ago

critch commented 7 years ago

This just changes some includes to contains so Class['yum'] will contain all the subclasses and allows before and require dependencies to work as a user would expect them to behave.

critch commented 7 years ago

Travis seems to fail some instances that it shouldn't due to a ruby version issue.

There are some failures that are due to the use of contain and when it became available. Not sure how you would want to deal with the minimum version issue. Contain showed up in PE3.2 and OSS 3.4.

As an example of why I wanted to see this change. I have a set of packages that come from a repo. I only need the repo when I am on a RHEL system. When on Debian, the packages are part of base. So the relationship from the package to the repo would fail on non RHEL systems. So I wanted to do a before on the repo to the package list. This ensures the system will have the repo before the packages are attempting to install.