Changed "latest" part in base_url

example42 / puppet-yum

Puppet module for Yum

Other

43 stars 116 forks source link

Changed "latest" part in base_url #93

Closed marknl closed 9 years ago

marknl commented 9 years ago

"latest" == 5.5latest, which is the standard.

alvagante commented 9 years ago

Even if totally sane this change could break existing setups which rely on the defined version. I'd in any case add a parameter to this sub class ($version) have by default the existing value (5.1latest) and leave to users the option to specify (on Hiera or wherever) a custom one. If you assure me that there should not be issues for existing setups in changes from 5.1latest to latest, then me might set latest as default value for such a parameter.

marknl commented 9 years ago

No, I cannot assure it will work. As soon as you update ESX to 5.5, newer vmwaretools become available in vCenter and I currently cannot confirm if 5.5 tools will work with ESX5.1, so maybe just leave this as is.