search

example42 / puppi

Puppet module to manage applications deployments and servers local management
http://www.example42.com
Other
142 stars 84 forks source link

Restore self::params lookup #152

Closed sathieu closed 6 years ago

sathieu commented 6 years ago

Needed for apt::dater.

alvagante commented 6 years ago

Can't we fix this on apt::dater by avoiding to use params_lookup there? params_lookup was always supposed to be used only on the main class, and not an any class. Mostly, the problem is that code was removed because it fails on puppet5 and hadn't found a sane way to fix it at the times

sathieu commented 6 years ago

I can change apt::dater but this will break setups using for example $apt_dater_package = 'myownpkg'.

This PR works on Puppet 5 (and Puppet 4).

alvagante commented 6 years ago

Thank you, tested on puppet 3, it doesn't seem to work on apt::dater but it doesn't break params_lookup, which was the most important thing.

sathieu commented 6 years ago

Thanks. On Puppet3, I thought that lib/puppet/parser/functions/params_lookup.rb was used ...

alvagante commented 6 years ago

@sathieu oh, right of course