search

examunity / bootstrap-rn

Bootstrap components for React Native
MIT License
2 stars 0 forks source link

Enhancement of components that are based on Text components #34

Closed markusjwetzel closed 1 year ago

markusjwetzel commented 2 years ago

For DropdownHeader, DropdownItemText, PopoverHeader and TooltipInner the vertical padding is currently not applied, because they are based on a Text component and the height of a Text component is equal to the defined line height.

It might be best to wrap these components in a View component and add a prop text of type object that passes down props to the inner Text component. Also if we wrap DropdownItemText in a View, we might also do it for NavbarText for consistency.

markusjwetzel commented 2 years ago

Somehow related is a bug on iOS for the PopoverHeader component that is based on the Heading -> Text component:

The component overflows on the right and the border radius is not applied. Using a View component here would fix this issue.

markusjwetzel commented 1 year ago

Fixed by 985f1c7d328bb38252b2d81abdf13c3de30d23b1.