scalarAvection does not exit with an error if wrong executor name is chosen

happyKitesurfer commented 2 hours ago

I wrote in the control dict

executor LPU;

However the application does not crash as supposed in setup.cpp:

NeoFOAM::Executor createExecutor(const dictionary& dict) { auto execName = dict.get("executor");

Info << execName << nl;

if (execName == "Serial")
{
    Info << "Serial executor chosen" << nl;
    return NeoFOAM::SerialExecutor();
}
else if (execName == "CPU")
{
    Info << "CPU executor chosen" << nl;
    return NeoFOAM::CPUExecutor();
}
else if (execName == "GPU")
{
    Info << "GPU executor chosen" << nl;
    return NeoFOAM::GPUExecutor();
}
else
{
    FatalError << "Executor not recognized" << endl;
}
Info << "executor chosen" << endl;
Info << execName << nl;
return NeoFOAM::SerialExecutor();

}

It actually goes always to the end of the if else conditions

happyKitesurfer commented 2 hours ago

Even if I type

executor GPU;

in the controlDict It goes to the end of the if else conditions

happyKitesurfer commented 1 hour ago

I think dict.get("executor");

returns a word object, i.e., https://www.openfoam.com/documentation/guides/latest/api/classFoam_1_1word.html.

Maybe the == operator gets fooled :)

happyKitesurfer commented 1 hour ago

Ok the topic of comparing word with string was already discussed here: