search

exasim-project / NeoFOAM

WIP Prototype of a modern CFD core
26 stars 3 forks source link

87 minor mpi corrections #105

Closed bevanwsjones closed 2 months ago

bevanwsjones commented 2 months ago

Small mainly name changes and adding some tests back in.

@greole can you check you happy with the thread support?

bevanwsjones commented 2 months ago

LGTM. I guess we should vote if we prefer irecv -> ireceive -> receive and isend -> send

@HenningScheufler @greole

So just FYI from the MPI docs: "In addition, for these functions a prefix of I (for immediate and incomplete) indicates that the call is nonblocking."

So think we leave it as 'i'

greole commented 2 months ago

LGTM. I guess we should vote if we prefer irecv -> ireceive -> receive and isend -> send

@HenningScheufler @greole

So just FYI from the MPI docs: "In addition, for these functions a prefix of I (for immediate and incomplete) indicates that the call is nonblocking."

I guess the point i am trying to make is that for example OpenFOAM and Ginkgo are just exposing general communication functions and whether blocking or non blocking communication is done is selected via build or run time flags. So in that sense one could maybe use implement a send and recv function that can do both. But thinking about it i guess i prefer being explicit in what we do and just call it isend and irecv as it is.