Fix CI/CD build issues - Githubissues

exasim-project / NeoFOAM

WIP Prototype of a modern CFD core

26 stars 3 forks source link

Fix CI/CD build issues #21

Closed greole closed 7 months ago

greole commented 7 months ago

This PR fixes several issues with our current build system:

Disables default build of tests and benchmarks
Moves Catch2 installation to separate CMakeLists
Use a default ubuntu container to run on
Fix initialization of structs without custom ctr
Remove double format check workflow
call unit tests

HenningScheufler commented 7 months ago

It looks good to me.

The only issue is may be the readme. New users coming from the OpenFOAM may not be familiar with cmake so there should be a copy-paste able instruction how to compile the library, run the test and benchmarks

HenningScheufler commented 7 months ago

The last thing missing is to update the changelog