search

exasim-project / NeoFOAM

WIP Prototype of a modern CFD core
25 stars 2 forks source link

Geometric field implementations #55

Closed HenningScheufler closed 2 months ago

HenningScheufler commented 5 months ago

Note .cmake-format needed to be changed from 80 to 100 lines

HenningScheufler commented 5 months ago

this PR requires the merge of PR

greole commented 4 months ago

this PR requires the merge of PR https://github.com/exasim-project/NeoFOAM/pull/53 and https://github.com/exasim-project/NeoFOAM/pull/54

Btw if you add - before the PR you get a nice label which shows the state of the PR

MarcelKoch commented 4 months ago

The PR seems to be quite complicated and large. I think it contains multiple changes which have some dependency between them. So far I've gathered:

  1. boundary fields interface
  2. boundary fields implementation for vol/surface fields
  3. vol/surface fields
  4. domain field

I think the dependencies are:

graph TD;
  1-->2
  3-->2
  4

I think splitting up the PR along these lines would help to discuss and review it.

HenningScheufler commented 4 months ago

The PR seems to be quite complicated and large. I think it contains multiple changes which have some dependency between them. So far I've gathered:

1. boundary fields interface

2. boundary fields implementation for vol/surface fields

3. vol/surface fields

4. domain field
  1. was already merged in #54 and due to the rename of domainField to DomainField it still appeared in files.

I added the description to the boundary condition and fvccVolField value to the documentation, which should be avialable here:

https://exasim-project.com/NeoFOAM/test_build/fvcc/fields.html

Note: for some reason the online documentation is not reliable update. So please build the documentation locally

greole commented 2 months ago

Closed in favour of https://github.com/exasim-project/NeoFOAM/pull/74