exasim-project / NeoFOAM

WIP Prototype of a modern CFD core
25 stars 2 forks source link

Refactor CI/CD implementation #60

Closed greole closed 4 months ago

greole commented 5 months ago

This PR consolidates our github workflows.

greole commented 5 months ago

@HendriceH I added the compile_on_aws.yaml workflow, but the workflow doesn't show up yet. Maybe the NeoFOAM repo needs do be enabled?

HendriceH commented 4 months ago

@HendriceH I added the compile_on_aws.yaml workflow, but the workflow doesn't show up yet. Maybe the NeoFOAM repo needs do be enabled?

Hi @greole, I think the workflow yaml file needs to be present in main, otherwise it won't show up. Other ideas would be the file ending: Does it need to be .yaml or .yml? Or does it need to be in a subdirectory "workflows"?

greole commented 4 months ago

The file name should be correct, I copied it from the ogl folder. Do we need to create some credentials/tokens? I think we did that for the hpsim repositories but not the exasim-project yet?

HendriceH commented 4 months ago

The file name should be correct, I copied it from the ogl folder. Do we need to create some credentials/tokens? I think we did that for the hpsim repositories but not the exasim-project yet?

Yes you need to create a token (with repository scope) and add it to the repository secrets -> actions under the name: GH_PERSONAL_ACCESS_TOKEN

greole commented 4 months ago

Ok I can start the job on aws now but it fails with: Error: Could not assume role with OIDC: Not authorized to perform sts:AssumeRoleWithWebIdentity see https://github.com/exasim-project/NeoFOAM/actions/runs/8990675598

greole commented 4 months ago

Just for reference, I won't add this PR to the Changelog since it mainly changes our CI/CD