exasim-project / OBR

A runner for OpenFOAM benchmarks
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

`find_logs` inner method `find_tags` does not work when there is a log file present. #176

Open lupeterm opened 7 months ago

lupeterm commented 7 months ago

Example:

└── fd52708db5c296d1fa52b056701be4ee
        ├── signac_job_document_6850e48aa71863aac82ca3c2cdd6d5e2_test_campaign.json
        ├── signac_job_document.json
        ├── signac_statepoint.json
        └── test_campaign
            ├── decomposePar_2024-01-05_17:38:44.log
            ├── instrumentedPimpleFoam_2024-01-05_17:44:32.log
            ├── solverExitCode.log
            └── test_tag
                ├── decomposePar_2024-01-05_17:38:44.log
                ├── instrumentedPimpleFoam_2024-01-05_17:44:32.log
                └── solverExitCode.log

How to reproduce:

  1. Call obr archive without specifying a tag
  2. Call obr apply
  3. Call obr archive with specifying a tag
  4. Call obr apply

Now, the folder structure will look like the above and the inner function find_tags will enter the first branch, setting tag_mapping[str(path)] = [] as the default value of tagsis the empty list. This results in the tags being ignored.