search

exasmr / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
MIT License
15 stars 9 forks source link

Fix bug in filter::type() dispatcher function #29

Closed jtramm closed 1 year ago

jtramm commented 1 year ago

@gridley found a nasty bug in the Filter type dispatching function, where two of the types were dispatching to each other's functions. Thanks @gridley for tracking this one down!

gridley commented 1 year ago

There are more typos in that block, it seems. E.g. peep CellInstance, which seems to map to "cellborn". I am also working on a PR that has a few changes like this and should get tests passing. Want to wait on that one instead?

gridley commented 1 year ago

Looks good to me! I'll rebase on this instead, then we can include other stuff later on.

jtramm commented 1 year ago

If there is a larger testing-oriented PR incoming, then I'm happy to hold off on this! However, if the testing PR is going to take more than a few days to finish up, might be good to put this one in for now, as no reason to let a bug like this sit for longer than needed.

gridley commented 1 year ago

Agreed, I've already rebased on this and it now has asymmetric_lattice passing, at least. Whereas before it would fail. So, I don't have access to approve or merge this, but please merge whenever is convenient.