search

exasol / dynamodb-virtual-schema

Virtual Schema for accessing Amazon AWS DynamoDB through Exasol
MIT License
1 stars 1 forks source link

Performance test setup #72

Closed jakobbraun closed 4 years ago

jakobbraun commented 4 years ago

Added test setup for AWS.

morazow commented 4 years ago

Overall looks good with minor requests.

I did not realize you use the terraform values from the Java tests. Since terraform creates cluster in the wild internet, it would be good to not disclose the credentials inside the code.

One approach to unify the sharing credentials between Terraform and Java tests would be to use git unchecked configuration file. 

terraform apply -var-file configs.tfvars

and then parse this as properties file in Java.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information