exasol / error-code-crawler-maven-plugin

Validator and crawler for exasol-error-codes in Java code
MIT License
1 stars 1 forks source link

Remove CVE-2020-8908 workaround #10

Closed jakobbraun closed 1 year ago

jakobbraun commented 3 years ago

After maven-core fixed CVE-2020-8908 (by updating the guava dependency) we can also remove the explicit exclude (added in 05dc12e) from the pom.xml again.

Additional vulnerability

redcatbear commented 3 years ago

According the the CVE the problem was fixed in version 30.0. Latest at the moment is 31.1.

https://search.maven.org/artifact/org.checkerframework.annotatedlib/guava

jakobbraun commented 3 years ago

yes, but mvn-core did not update the dependency yet:

[INFO] +- org.apache.maven:maven-core:jar:3.8.1:compile [INFO] | +- com.google.inject:guice:jar:no_aop:4.2.1:compile [INFO] | | +- com.google.guava:guava:jar:25.1-android:compile

kaklakariada commented 2 years ago

Still not fixed in 3.8.4:

[INFO] +- org.apache.maven:maven-core:jar:3.8.4:provided
...
[INFO] |  +- com.google.inject:guice:jar:no_aop:4.2.2:provided
[INFO] |  |  +- aopalliance:aopalliance:jar:1.0:provided
[INFO] |  |  \- com.google.guava:guava:jar:25.1-android:provided
kaklakariada commented 2 years ago

Still not fixed in 3.8.6:

[INFO] +- org.apache.maven:maven-core:jar:3.8.6:provided
...
[INFO] |  +- com.google.inject:guice:jar:no_aop:4.2.2:provided
[INFO] |  |  +- aopalliance:aopalliance:jar:1.0:provided
[INFO] |  |  \- com.google.guava:guava:jar:25.1-android:provided
redcatbear commented 2 years ago

Version number for guice is not pinned in maven-core. Latests guice is 5.1. And it looks like this guice does not pin Guava. @kaklakariada , what am I overlooking here?

kaklakariada commented 2 years ago

You mean we could explicitly upgrade the transitive dependency guava? That would be an option, you are right. Unblocking this.

ckunki commented 1 year ago

After overriding dependency to guice 4.2.2 by 5.1.0 I still get

I propose to keep the current workaround: exclude dependency to guava.