search

exasol / exasol-rest-api

REST API for Exasol
MIT License
2 stars 0 forks source link

Improve JSON assertions in tests #13

Closed AnastasiiaSergienko closed 1 year ago

AnastasiiaSergienko commented 3 years ago

As @jakobbraun suggested, we can use additional library for more readable JSON assertions in tests: https://github.com/kinbiko/jsonassert

AnastasiiaSergienko commented 3 years ago

Additional improvements for tests: check if assertAll exists in some go library.

kaklakariada commented 3 years ago

assertAll is not necessary with go. When using assertions like this:

suite.Equal(len(hosts), 3)
suite.Equal("exasol1", hosts[0])

both assertions will be executed and you will get two failure messages in case of a mismatch.

pj-spoelders commented 1 year ago

Closing this ticket. Has little relevancy today. If anyone disagrees feel free to open it again or create a new ticket.