search

exasol / exasol-testcontainers

Test container for Exasol on Docker
MIT License
9 stars 2 forks source link

Remove duplicate classes from dependencies #224

Closed kaklakariada closed 1 year ago

kaklakariada commented 1 year ago

Maven plugin duplicate-finder-maven-plugin fails in the trino project when checking dependency com.exasol:exasol-testcontainers:6.5.1:

[INFO] --- duplicate-finder-maven-plugin:1.5.1:check (default) @ trino-exasol ---
[INFO] Checking compile classpath
[INFO] Checking runtime classpath
[INFO] Checking test classpath
[WARNING] Found duplicate (but equal) classes in [com.exasol:bucketfs-java:3.0.0, com.exasol:exasol-testcontainers:6.5.1]:
[WARNING]   com.exasol.config.BucketConfiguration
[WARNING] Found duplicate (but equal) classes in [jakarta.json:jakarta.json-api:2.1.1, org.glassfish:jakarta.json:2.0.1]:
[WARNING]   jakarta.json.JsonArray
[WARNING]   jakarta.json.JsonArrayBuilder
[WARNING]   jakarta.json.JsonBuilderFactory
[WARNING]   jakarta.json.JsonMergePatch
[WARNING]   jakarta.json.JsonNumber
[WARNING]   jakarta.json.JsonObject
[WARNING]   jakarta.json.JsonObjectBuilder
[WARNING]   jakarta.json.JsonPatch
[WARNING]   jakarta.json.JsonPatchBuilder
[WARNING]   jakarta.json.JsonPointer
[WARNING]   jakarta.json.JsonReader
[WARNING]   jakarta.json.JsonReaderFactory
[WARNING]   jakarta.json.JsonString
[WARNING]   jakarta.json.JsonStructure
[WARNING]   jakarta.json.JsonValue
[WARNING]   jakarta.json.JsonWriter
[WARNING]   jakarta.json.JsonWriterFactory
[WARNING]   jakarta.json.stream.JsonGenerator
[WARNING]   jakarta.json.stream.JsonGeneratorFactory
[WARNING]   jakarta.json.stream.JsonLocation
[WARNING]   jakarta.json.stream.JsonParserFactory
[WARNING] Found duplicate and different classes in [com.exasol:bucketfs-java:3.0.0, com.exasol:exasol-testcontainers:6.5.1]:
[WARNING]   com.exasol.config.BucketFsServiceConfiguration
[WARNING] Found duplicate and different classes in [jakarta.json:jakarta.json-api:2.1.1, org.glassfish:jakarta.json:2.0.1]:
[WARNING]   jakarta.json.EmptyArray
[WARNING]   jakarta.json.EmptyObject
[WARNING]   jakarta.json.Json
[WARNING]   jakarta.json.JsonException
[WARNING]   jakarta.json.JsonValueImpl
[WARNING]   jakarta.json.spi.JsonProvider
[WARNING]   jakarta.json.stream.JsonCollectors
[WARNING]   jakarta.json.stream.JsonGenerationException
[WARNING]   jakarta.json.stream.JsonParser
[WARNING]   jakarta.json.stream.JsonParsingException
[WARNING] Found duplicate classes/resources in test classpath.

The workaround is to skip the plugin by setting property air.check.skip-duplicate-finder to true.

kaklakariada commented 1 year ago

Root cause is in bucketfs-java:

[INFO] +- com.exasol:bucketfs-java:jar:3.0.0:compile
[INFO] |  +- com.exasol:error-reporting-java:jar:1.0.0:compile
[INFO] |  +- jakarta.json:jakarta.json-api:jar:2.1.1:compile
[INFO] |  +- org.glassfish:jakarta.json:jar:2.0.1:runtime
[INFO] |  +- jakarta.json.bind:jakarta.json.bind-api:jar:3.0.0:compile
[INFO] |  \- org.eclipse:yasson:jar:3.0.2:compile
[INFO] |     \- org.eclipse.parsson:parsson:jar:1.1.0:compile

After this is fixed in https://github.com/exasol/bucketfs-java/issues/59 we need to upgrade bucketfs-java here.