exasol / github-keeper

Tool for unifying our GitHub repository setup. Superseded by github-issue-adapter
MIT License
2 stars 1 forks source link

Unfeasable branch protection rules #57

Closed Nicoretti closed 2 years ago

Nicoretti commented 2 years ago

Due to the fact that pushing directly to master/main is prohibited in our repositories, adding branch protection rules which require the execution of workflows/actions on the following event:

on:
  push:
    branches:
      - main

will render PR's unmergeable (without administrative intervention e.g. deleting the specific branch protection rules). For example see this PR.

image

Impact

The project never will be Github-Keeper compliant.

  1. If it is complaint: PR's can't get merged
  2. If it is manually fixed by adjusting the protection rules: The project won't be complaint

Root cause

Github-Keeper does not seem to take triggers of workflow/actions into account correctly.