Closed Nicoretti closed 2 years ago
@Nicoretti We actually have cleanup code in place on multiple levels which reacts to SIGINT. The tasks which are starting the DB, remove it when one of them fail and the Test abstraction cleans up as well and the teardowns, too. Can you confirm it was a single CTRL+C, because I so far only saw leftovers after a double CTRL+C which is more or less a SIGKILL. This can also happen easily, because the cleanup takes a while.
@tkilias I am quite confident I pressed it at least twice. So I don't think it is a bug in this case. Still I don't think pressing 2x ctrl + c
ending up being a "SIGKILL" is obvious to an end user. We may should add a warning regarding this.
@tkilias just validated it, 1x ctrl + c
works well but 2x ctrl + c
may leave leftovers behind. So I would say it isn't a bug.
Current Implementation:
ctrl + c
the end user gets informed that the "program" is shutting downctrl + c
the end user gets the message Aborted!
To sum it up: It works as expected, but the implication(s) of the Aborted!
could be made more clear.
@tkilias just validated it, 1x
ctrl + c
works well but 2xctrl + c
may leave leftovers behind. So I would say it isn't a bug.Current Implementation:
* On the first `ctrl + c` the end user gets informed that the "program" is shutting down * On the second `ctrl + c` the end user gets the message `Aborted!`
To sum it up: It works as expected, but the implication(s) of the
Aborted!
could be made more clear.
@Nicoretti
Hm, interesting, I am actually not sure, where the message Aborted!
comes from.
Attention:
Steps to reproduce:
scripts/test/run_all_tests.sh
docker ps
)STRG + C
(SIGINT)docker rm <hash> ...
docker image prune
Root Cause: As of now, it looks like the left behind Exasol DB container causes test failures in successive test executions.
Possible strategies to address this bug:
STRG + C
Known Issues
Potentially related issues: