Closed tomuben closed 1 year ago
GOOGLE_CLOUD_BUILD is used to signify the creation of
these do not seem google cloud specific, should we rename them as well? also, should this change be documented somewhere?
GOOGLE_CLOUD_BUILD is used to signify the creation of
google_cloud_parameter = ExaslctDockerTestEnvironment(..) SpawnedTestEnvironments.google_cloud_environment these do not seem google cloud specific, should we rename them as well? also, should this change be documented somewhere?
I think you could rename the variable name also within the scope of this ticket.
Background
We used the environment variable
GOOGLE_CLOUD_BUILD
for the Google Cloud Ci builds. However, as we switched to AWS recently, this name is quit confusing. The variable is used to create the temp directory within the current working directory. This could be still useful in the future when we need to run tests again within another container. So, we should rename the variable to a more generic name, which indicates also the purpose of the variableAcceptance
Rename all occurences of
GOOGLE_CLOUD_BUILD
toRUN_SLC_TESTS_WITHIN_CONTAINER