search

exasol / integration-test-docker-environment

A docker-based environment for integration tests with the EXASOL DB.
https://exasol.github.io/integration-test-docker-environment/
MIT License
6 stars 2 forks source link

Rename test environment variable #241

Closed tomuben closed 1 year ago

tomuben commented 2 years ago

Background

We used the environment variable GOOGLE_CLOUD_BUILD for the Google Cloud Ci builds. However, as we switched to AWS recently, this name is quit confusing. The variable is used to create the temp directory within the current working directory. This could be still useful in the future when we need to run tests again within another container. So, we should rename the variable to a more generic name, which indicates also the purpose of the variable

Acceptance

Rename all occurences of GOOGLE_CLOUD_BUILD to RUN_SLC_TESTS_WITHIN_CONTAINER

MarleneKress79789 commented 1 year ago

GOOGLE_CLOUD_BUILD is used to signify the creation of

these do not seem google cloud specific, should we rename them as well? also, should this change be documented somewhere?

tomuben commented 1 year ago

GOOGLE_CLOUD_BUILD is used to signify the creation of

google_cloud_parameter = ExaslctDockerTestEnvironment(..) SpawnedTestEnvironments.google_cloud_environment these do not seem google cloud specific, should we rename them as well? also, should this change be documented somewhere?

I think you could rename the variable name also within the scope of this ticket.