search

exasol / integration-test-docker-environment

A docker-based environment for integration tests with the EXASOL DB.
https://exasol.github.io/integration-test-docker-environment/
MIT License
6 stars 2 forks source link

Check usage of significant=False in luigi Parameters #254

Open tomuben opened 1 year ago

tomuben commented 1 year ago

Background

since we introduced the API, it might become interesting for clients to spawn environments 2x (with same environment name!). Currently we use significant=False on luigi parameters in some of the tasks for spawn database, which would be in conflict with this requirements, for example: https://github.com/exasol/integration-test-docker-environment/blob/5492d0b66641eb666667a9b8d1be7a9704c4efa6/exasol_integration_test_docker_environment/lib/test_environment/database_waiters/wait_for_test_docker_database.py#L23

Acceptance Criteria

Re-evaluate usage of significant=False on all luigi parameters, considering this new requirement.