search

exasol / integration-test-docker-environment

A docker-based environment for integration tests with the EXASOL DB.
https://exasol.github.io/integration-test-docker-environment/
MIT License
6 stars 2 forks source link

Refactor parameters of luigi tasks #356

Open ckunki opened 1 year ago

ckunki commented 1 year ago

Currently luigi tasks are using separate parameters for port specification.

E.g. class DockerDBTestEnvironmentParameter uses 3 separate parameters 

    database_port_forward = luigi.OptionalParameter(None, significant=False)
    bucketfs_port_forward = luigi.OptionalParameter(None, significant=False)
    ssh_port_forward = luigi.OptionalParameter(None, significant=False)

The current ticket proposes to combine these parameters into a single parameter of type Ports:

    port_forwards =  JsonPickleParameter(Ports, significant=False)