search

exasol / kafka-connector-extension

Exasol Kafka Extension for accessing Apache Kafka
MIT License
4 stars 7 forks source link

Import JSON Records from Kafka (from #24) #25

Closed baunz closed 3 years ago

baunz commented 3 years ago

This is a sketch on how to make this library import json records. The json conversion is rather basic as the main goal was to import the json as-is with the ÀS_JSON_DOC option, but the new RECORD_FIELDS option adds some value to the avro path as well: Right now a change in the record schema like field additions or removals or even a simple reordering of fields (which is possible) would break the import or just insert field values in the wrong columns.

morazow commented 3 years ago

Hello @baunz,

Thank a lot for the feedback and pull request!

Sorry for not replying earlier, I am going to review it soon.

morazow commented 3 years ago

Hello @baunz,

I have added some review suggestions. Please have a look.

Thanks again! It is nice feature.

baunz commented 3 years ago

Hi @morazow , thanks for taking the time too look at it! I will adress your comments in a new commit..

morazow commented 3 years ago

I am going to merge this now.

Release will come later, but meanwhile you could still use the assembled jar file.