Closed millin closed 3 years ago
Hello @millin,
This is great! Thanks for the pull request! I am going to review it soon.
I reverted all removed parentheses, but found that usage of methods with/without parentheses are currently mixed:
Thanks @millin. Yes, there are still the cases from early development, I would appreciate if you could also add parentheses to these methods.
Hello @millin,
I have added changes files and run formatter (unfortunately CI task do not run on remote forks).
Could you please add short import example using sasl protocol to user guide? Another subsection with sasl example would be fine on user guide secure connection part. Then we can merge the pull request.
Hello @morazow,
I'm working on it, I will make a commit soon.
Great, thanks!
Please do not forget to pull last to commits I have added.
@morazow Please review
Great, looks good!
Hi everyone! This is Alexander Millin from Citymobil.
I added the ability to connect to Kafka with SASL_PLAINTEXT or SASL_SSL security protocols. I tested it in our environment with SASL_SSL and it seems to work fine.
Please kindly review. If necessary, you are free to modify this or ask me to fix something, as I have never written on Scala before :smile: