exasol / kafka-connector-extension

Exasol Kafka Extension for accessing Apache Kafka
MIT License
4 stars 7 forks source link

Add SASL_PLAINTEXT/SASL_SSL security protocols #47

Closed millin closed 3 years ago

millin commented 3 years ago

Hi everyone! This is Alexander Millin from Citymobil.

I added the ability to connect to Kafka with SASL_PLAINTEXT or SASL_SSL security protocols. I tested it in our environment with SASL_SSL and it seems to work fine.

Please kindly review. If necessary, you are free to modify this or ask me to fix something, as I have never written on Scala before :smile:

morazow commented 3 years ago

Hello @millin,

This is great! Thanks for the pull request! I am going to review it soon.

millin commented 3 years ago

I reverted all removed parentheses, but found that usage of methods with/without parentheses are currently mixed:

https://github.com/exasol/kafka-connector-extension/blob/0cfa53936c32d286af57d2bbcd45d7725b361a1e/src/test/scala/com/exasol/cloudetl/kafka/KafkaConsumerPropertiesTest.scala#L35

https://github.com/exasol/kafka-connector-extension/blob/0cfa53936c32d286af57d2bbcd45d7725b361a1e/src/test/scala/com/exasol/cloudetl/kafka/KafkaConsumerPropertiesTest.scala#L154

morazow commented 3 years ago

Thanks @millin. Yes, there are still the cases from early development, I would appreciate if you could also add parentheses to these methods.

morazow commented 3 years ago

Hello @millin,

I have added changes files and run formatter (unfortunately CI task do not run on remote forks).

Could you please add short import example using sasl protocol to user guide? Another subsection with sasl example would be fine on user guide secure connection part. Then we can merge the pull request.

millin commented 3 years ago

Hello @morazow,

I'm working on it, I will make a commit soon.

morazow commented 3 years ago

Great, thanks!

Please do not forget to pull last to commits I have added.

millin commented 3 years ago

@morazow Please review

morazow commented 3 years ago

Great, looks good!