search

exasol / mysql-virtual-schema

Virtual Schema for connecting MySQL as a data source to Exasol
MIT License
2 stars 0 forks source link

VSMYSQL CREATE ADAPTER SCRIPT in User Guide #36

Closed allipatev closed 11 months ago

allipatev commented 1 year ago

Customer had a problem because of --/ before the line

CREATE OR REPLACE JAVA ADAPTER SCRIPT SCHEMA_FOR_VS_SCRIPT.ADAPTER_SCRIPT_MYSQL AS

as SQL clients other then DB Visualizer might find the script body to send to DB incorrectly in this case.

Please consider adding a remark to the User guide that the comment ('--/') will is ONLY necessary for a DB Visualizer SQL client and not for others.

ckunki commented 11 months ago

Already solved with #26

ckunki commented 11 months ago

See https://github.com/exasol/mysql-virtual-schema/blob/main/doc/user_guide/mysql_user_guide.md#installing-the-adapter-script

ckunki commented 11 months ago

Hello @allipatev sorry I misread the current ticket.

ckunki commented 11 months ago

Hello @allipatev I also checked the official documentation at docs.exasol.com and noticed

Currently in in VSMYSQL user guide the line before the CREATE ADAPTER is a comment and should be ignored by SQL clients AFAIK. I also checked the script with SQL Client DBeaver without any problems which means for DBeaver the first line is not required but also not harmful.

If possible I also would prefer to keep the documentation as simple and straight-forward as possible, i.e. avoid if-then cases describing different scenarios whenever possible.

Would it be acceptable in your eyes if VSMYSQL user guide would use the same phrasing as the official documentation?