exasol / notebook-connector

Connection configuration management and additional tools for Jupyter notebooks.
MIT License
0 stars 0 forks source link

Check Docker Setup in Github Actions #96

Open tkilias opened 3 months ago

tkilias commented 3 months ago

The test_itde_manager.py assumes that, we run on the host and not in a container. However, certain CI do a docker-in-docker setup by mounting the docker-socket in the container which runs the CI scripts. This would change what we test in these tests, and that should be avoided.

Idea: Add docker ps -a to the Github Workflow and check if you a see a container that is not yours

Further, we maybe should add a check if we are in a container or not to these tests.

If the Github CI is running in a Container then we probably need to parameterize https://github.com/exasol/notebook-connector/blob/ad39d29173480090434726e6203b29c145944b38/test/integration/test_itde_manager_in_docker_container.py#L188 to create two containers one with the default docker network and one with a host network.