search

exasol / pyexasol

Exasol Python driver with low overhead, fast HTTP transport and compression
MIT License
72 stars 39 forks source link

Wrong parameter assert for EXPORT #57

Closed derolli1976 closed 4 years ago

derolli1976 commented 4 years ago

For the "DELIMIT" parameter the correct parameter value for "no delimiters" is "NEVER" rather than "NONE". The way this is implemented in http_transport.py the paramter does not work with EXASOL 6.X

derolli1976 commented 4 years ago

Suggestion; Change line 124 in http_transport.py

old: if delimit != 'AUTO' and delimit != 'ALWAYS' and delimit != 'NONE':

new: if delimit != 'AUTO' and delimit != 'ALWAYS' and delimit != 'NEVER':

littleK0i commented 4 years ago

Hi @derolli1976 ,

Thank you for pointing this out. Option NEVER is quite unsafe, so it's very rarely used in practice.

Fixed in 0.14.1. Full commit: https://github.com/badoo/pyexasol/commit/c062c7b22780109453a29d7e5150396f07a66642

Thank you.

littleK0i commented 4 years ago

@derolli1976 , Hello,

Just a quick check. How did it go with the latest update introducing NEVER delimit?

Thank you.

derolli1976 commented 4 years ago

Hey, sorry for the late reply. The corrected parameter is working perfectly! Thanks a lot!