search

exasol / python-toolbox

Infrastructure & Automation Tooling for Python Projects
https://exasol.github.io/python-toolbox/
MIT License
2 stars 0 forks source link

✨ Generated GitHub workflow files: Inherit GitHub secrets by default #162

Closed ckunki closed 3 months ago

ckunki commented 4 months ago

Observed behavior

I had some trouble to run integration tests in my CI build, which required using GitHub secrets for accessing an Exasol SaaS database instance, see saas-api-python.

Some of the GitHub workflows generated by the PTB use the trigger workflow_call. In this case, secrets are not inherited by default.

Proposed Fix

Update file .github/workflows/ci.yml generated by PTB and add 

  ci-job:
    name: Checks
    uses: ./.github/workflows/checks.yml
    secrets: inherit

If you have security concerns, then we could add this as a comment and add some documentation.